fix: remove deprecated xblock.fragment import#130
Open
UsamaSadiq wants to merge 1 commit intomasterfrom
Open
Conversation
Agrendalath
requested changes
Aug 13, 2024
| from xblock.fragment import Fragment | ||
| try: | ||
| from web_fragments.fragment import Fragment | ||
| except: |
Member
There was a problem hiding this comment.
https://peps.python.org/pep-0008/#programming-recommendations
A bare
except:clause will catch SystemExit and KeyboardInterrupt exceptions, making it harder to interrupt a program with Control-C, and can disguise other problems. If you want to catch all exceptions that signal program errors, useexcept Exception:(bare except is equivalent to except BaseException:).
Comment on lines
+43
to
+44
| # for backwards compatibility with quince and prior releases | ||
| from xblock.fragment import Fragment |
Member
There was a problem hiding this comment.
Do we need this? The Drag and Drop v2 XBlock has been working without such a fallback for over four years: openedx/xblock-drag-and-drop-v2@5334f4d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This replace
xblock.fragmentwithweb_fragments.fragment.xblock.fragmentwas removed as of 2024-02-26. If this xblock is used in a course, the entire course will fail to load.