Skip to content

Conversation

@salman2013
Copy link
Contributor

@salman2013 salman2013 commented Aug 11, 2025

Description:

When we extracted problem xblock code from edx-platform to xblocks-contrib few tests under xblocks_contrib/problem/capa/ was failing. Most of the issues were path related or pylint quality errors.

In this PR i update and ensure all unit tests in xblocks_contrib/problem/capa/ pass independently, using mock services or fixtures where needed.

The changes in this PR will be merge in the main PR for the problem xblock extraction.

Parent Ticket: openedx/edx-platform#36538

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 11, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 11, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 14, 2025
Copy link
Member

@irtazaakram irtazaakram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes for file outside capa folder in xblocks-contrib/problem

"Failed to connect to codejail api service: url=%s, params=%s", codejail_service_endpoint, str(payload)
)
raise CodejailServiceUnavailable(
_("Codejail API Service is unavailable. " "Please try again in a few minutes.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_("Codejail API Service is unavailable. " "Please try again in a few minutes.")
_("Codejail API Service is unavailable. Please try again in a few minutes.")

@salman2013 salman2013 requested a review from irtazaakram August 19, 2025 08:31
@irtazaakram irtazaakram merged commit dfaeed1 into problemblock Aug 19, 2025
11 of 12 checks passed
@irtazaakram irtazaakram deleted the salman/extract-problem-block branch August 19, 2025 08:34
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants