-
Notifications
You must be signed in to change notification settings - Fork 4
Fix tests under capa/tests #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a7a1eda to
bedd1e1
Compare
897cec0 to
697ab72
Compare
irtazaakram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes for file outside capa folder in xblocks-contrib/problem
| "Failed to connect to codejail api service: url=%s, params=%s", codejail_service_endpoint, str(payload) | ||
| ) | ||
| raise CodejailServiceUnavailable( | ||
| _("Codejail API Service is unavailable. " "Please try again in a few minutes.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| _("Codejail API Service is unavailable. " "Please try again in a few minutes.") | |
| _("Codejail API Service is unavailable. Please try again in a few minutes.") |
Description:
When we extracted problem xblock code from edx-platform to xblocks-contrib few tests under xblocks_contrib/problem/capa/ was failing. Most of the issues were path related or pylint quality errors.
In this PR i update and ensure all unit tests in xblocks_contrib/problem/capa/ pass independently, using mock services or fixtures where needed.
The changes in this PR will be merge in the main PR for the problem xblock extraction.
Parent Ticket: openedx/edx-platform#36538