-
Notifications
You must be signed in to change notification settings - Fork 4
Run Karma JS tests #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
13364a6 to
61d6c4b
Compare
|
Converting this to draft until the tests are fixed. |
|
Ah, gotcha, sounds good, sorry, I missed that. |
irtazaakram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the context that only javascript tests are fixed in this PR.
Description
Add Karma JS test for extracted video block.
This PR is pointing to Video block extraction #83 and will be merge in that, the scope we defined for this ticket was just to green Karma JS tests. All other tests will be fix in parent PR. #83
Parent PR: #83
Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=133624767&issue=openedx%7Cedx-platform%7C37479
How to run Karma tests locally:
Install dependencies Requirements:
How to run karma tests:
npm run build-devcommand to build webpack config in development mode.npx karma start xmodule/js/karma_xmodule_webpack.conf.js --log-level debug --single-runto run tests.We can run karma tests on tutor dev container by following steps:
Run container and install dependencies:
How to run karma tests:
npm run test-xmodule-webpackNote: I tested this PR by running karma tests outside container.