Skip to content

fix(otel): OPENFGA_TRACE_OTLP_TLS_ENABLED boolean flag quote #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yannchabed wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(otel): OPENFGA_TRACE_OTLP_TLS_ENABLED boolean flag quote #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3608a29
fix(otel): OPENFGA_TRACE_OTLP_TLS_ENABLED boolean flag quote
yannchabed Jan 27, 2026
44578a0
Merge branch 'main' into fix/trace-otlp-enabled-flag-quote
yannchabed Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/openfga/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ spec:

{{- if .Values.telemetry.trace.otlp.tls.enabled }}
- name: OPENFGA_TRACE_OTLP_TLS_ENABLED
value: {{ .Values.telemetry.trace.otlp.tls.enabled }}
value: "{{ .Values.telemetry.trace.otlp.tls.enabled }}"
{{- end }}
Comment on lines 383 to 386
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI chart-testing install uses default values (where telemetry.trace.otlp.tls.enabled is false), so this rendering path likely isn’t exercised in tests. Consider adding a charts/openfga/ci/ values file (used by chart-testing) that sets telemetry.trace.otlp.tls.enabled=true to prevent regressions and ensure the env var renders as a string.

Copilot uses AI. Check for mistakes.
Comment on lines 383 to 386
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says this change "includes" OPENFGA_TRACE_OTLP_TLS_ENABLED in the deployment, but this template block already existed; the actual change is quoting/casting the value. It may be worth updating the PR description to avoid confusion for reviewers and release notes.

Copilot uses AI. Check for mistakes.

{{- if .Values.telemetry.trace.sampleRatio }}
Expand Down
Loading