Correction tests sync#4
Open
samuelyao107 wants to merge 10 commits intoopenflexo-team:1.6.1from
Open
Conversation
When applying remote operations, AtomicEdits were incorrectly tagged with the local replicaId instead of the remote replica's ID. This caused the UndoManager to not filter out remote edits properly. Changes: - Added ThreadLocal<String> currentRemoteReplicaId in SyncEditingContext - Added getCurrentOperationReplicaId() method that returns the remote replicaId when applying a remote operation, otherwise the local one - Modified onOperationReceived() to set currentRemoteReplicaId before applying remote operations - Modified onStateReceived() to set currentRemoteReplicaId before restoring from snapshot - Updated ProxyMethodHandler.getCurrentReplicaId() to use the new getCurrentOperationReplicaId() method Now each replica can only undo its own AtomicEdits, not those from other replicas. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Modification Undo manager (Ginger part)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.