feat(Taxonomy): children method parity with parent methods#467
Open
Freso wants to merge 4 commits intoopenfoodfacts:developfrom
Open
feat(Taxonomy): children method parity with parent methods#467Freso wants to merge 4 commits intoopenfoodfacts:developfrom
Freso wants to merge 4 commits intoopenfoodfacts:developfrom
Conversation
github-project-automation
Bot
moved this to In progress
in 🐍 Python SDK - Keep on par with the API
There are currently a handful of functions that handle parentage lookups. Two of these methods currently only exist for parents and are a lacking a “child” equivalent. This adds TaxonomyNode.is_child_of() and .get_children_hierarchy(), copying the logic of their `parent[s]` method equivalents.
Freso
force-pushed
the
feat/taxonomy-child-methods
branch
from
5e59f79 to
f519cec
Compare
|
raphodn
approved these changes
Apr 25, 2026
github-project-automation
Bot
moved this from In progress
to Reviewer approved
in 🐍 Python SDK - Keep on par with the API
raphodn
changed the title
raphodn
reviewed
Apr 25, 2026
|
|
raphodn
reviewed
May 1, 2026
| ), | ||
| ( | ||
| category_taxonomy, | ||
| "en:brown-rices", |
Member
There was a problem hiding this comment.
the tests depend on the actual taxonomy.. which means that if the brown-rices sub-categories change, well the test will fail and need to be updated 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solution
TaxonomyNode.is_child_of()and.get_children_hierarchy(), copying the logic of theirparent[s]method equivalents.Related issue(s)