Reduce memory cost of liquid properties#69
Reduce memory cost of liquid properties#69jthorton wants to merge 2 commits intoopenforcefield:mainfrom
Conversation
|
@jthorton are you still keen on this PR? If so the tests are failing on formatting -- would you mind having a look at that? |
|
I’m not planning on using this PR for now. I think it would be useful in the future to have a wider range of closures that are more memory-efficient. For example, I’m currently using the energies target, and using a |
|
Ok, thanks @JMorado! In that case I'll close this PR for now and we can reopen the discussion when memory becomes more of an issue. |
Description
Try to reduce the memory cost of running a batch of liquid properties by running one by one and summing the gradients. The downside is that we lose any savings in the simulation deduplication as the planner does not know about other simulations which have been run.
Status