Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 86.58% 86.63% +0.05%
==========================================
Files 9 9
Lines 693 778 +85
==========================================
+ Hits 600 674 +74
- Misses 93 104 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hi @fjclark - We saw you checked "ready to go" on this. Would you like this reviewed in preparation to merge, or do you plan to continue making changes to this branch? |
Collaborator
Author
|
Hi @j-wags thanks for following up. Please hang off for the moment in case we decide a different functional form is better (I think this is ready to go if not). I'll comment again when we're sure this is final. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add terms which couple proper torsions and bond angles. From the
ProperTorsionBendHandlerdocstring:Status
Please hang off reviewing until we decide whether or not to tweak the functional form.