Merged
Conversation
…surveys-list-slowness
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve responsiveness in the surveys area by updating table column handling, reducing expensive UI sections when disabled via env config, and aligning survey status values with localized labels.
Changes:
- Bump
@openforis/arena-serverdependency to^1.2.20. - Localize survey status display (dashboard + surveys list) and introduce i18n resources for status labels.
- Update table visible-column computation and optionally hide the Activity Log dashboard tab via
ENV.activityLogDisabled.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates lockfile for @openforis/arena-server@^1.2.20. |
| package.json | Bumps @openforis/arena-server to ^1.2.20. |
| webapp/views/App/views/Home/Dashboard/SurveyInfo/SurveyInfo.js | Replaces raw status rendering with surveysView.status.* i18n key. |
| webapp/views/App/views/Home/Dashboard/Dashboard.js | Adds ENV.activityLogDisabled guard to avoid rendering Activity Log tab. |
| webapp/components/survey/Surveys/Surveys.js | Localizes status column and maps published-draft to published for non-editors. |
| webapp/components/Table/useTable.js | Refactors visible column keys/columns derivation logic. |
| server/modules/survey/manager/surveyManager.js | Minor refactor (let→const) and JSDoc edits for insertSurvey. |
| core/survey/_survey/surveyInfo.js | Changes survey status constants to lowercase/hyphenated keys. |
| core/i18n/resources/en/common.js | Adds surveysView.status translations. |
| core/i18n/resources/es/common.js | Adds surveysView.status translations. |
| core/i18n/resources/mn/common.js | Adds surveysView.status translations. |
| core/i18n/resources/pt/common.js | Adds surveysView.status translations. |
| core/i18n/resources/ru/common.js | Adds surveysView.status translations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets perceived slowness in the surveys/home experience by updating the Arena server dependency, adjusting dashboard tabs behavior, and improving how survey status is represented and localized across the UI.
Changes:
- Bump
@openforis/arena-serverto^1.2.20(lockfile + package.json). - Switch survey status values to lowercase keys and render localized status labels via
surveysView.status.*translations. - Add an env-flag gate to hide the Dashboard Activity Log tab when
ACTIVITY_LOG_DISABLEDis enabled.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates lockfile for @openforis/arena-server version bump. |
| package.json | Bumps @openforis/arena-server dependency to ^1.2.20. |
| core/survey/_survey/surveyInfo.js | Changes survey status constants to lowercase values. |
| core/i18n/resources/en/common.js | Adds surveysView.status.* translations (EN). |
| core/i18n/resources/es/common.js | Adds surveysView.status.* translations (ES). |
| core/i18n/resources/pt/common.js | Adds surveysView.status.* translations (PT). |
| core/i18n/resources/ru/common.js | Adds surveysView.status.* translations (RU). |
| core/i18n/resources/mn/common.js | Adds surveysView.status.* translations (MN). |
| webapp/views/App/views/Home/Dashboard/Dashboard.js | Conditionally includes Activity Log tab based on ProcessUtils.ENV.activityLogDisabled. |
| webapp/views/App/views/Home/Dashboard/SurveyInfo/SurveyInfo.js | Displays localized survey status in dashboard header. |
| webapp/components/survey/Surveys/Surveys.js | Displays localized survey status in surveys table (with published-draft mapping for non-editors). |
| webapp/components/Table/useTable.js | Refactors visible column keys computation (but introduces an unsafe optional-chaining issue). |
| server/modules/survey/manager/surveyManager.js | Minor refactor and JSDoc edits around insertSurvey. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.