Data import delete existing entities: code cleanup#4159
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs small cleanup/refactor changes in the data-import “delete existing entities” flow and aligns related UI/job i18n strings (mostly capitalization and a new job label entry).
Changes:
- Refactor entity node UUID collection in
EntitiesDeleteJobfromreduceto an explicitfor...ofloop. - Minor internal cleanup in
DataImportBaseJob.persistUpdatedNodes(avoid buildingnodesArraywhendryRunis true) and docblock whitespace. - Add
EntitiesDeleteJobjob label and normalize capitalization for “delete existing entities” option text across locales.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/modules/dataImport/service/DataImportJob/EntitiesDeleteJob.js | Refactors node UUID collection logic without changing behavior. |
| server/modules/dataImport/service/DataImportJob/DataImportBaseJob.js | Small cleanup to defer Object.values(nodesUpdated) until after dryRun short-circuit; removes extra doc whitespace. |
| core/i18n/resources/en/jobs.js | Adds EntitiesDeleteJob label and capitalizes DataDeleteJob. |
| core/i18n/resources/en/common.js | Capitalizes deleteExistingEntities option label. |
| core/i18n/resources/es/jobs.js | Adds EntitiesDeleteJob label. |
| core/i18n/resources/es/common.js | Capitalizes deleteExistingEntities option label. |
| core/i18n/resources/mn/jobs.js | Adds EntitiesDeleteJob label. |
| core/i18n/resources/mn/common.js | Capitalizes deleteExistingEntities option label. |
| core/i18n/resources/pt/jobs.js | Adds EntitiesDeleteJob label. |
| core/i18n/resources/pt/common.js | Capitalizes deleteExistingEntities option label. |
| core/i18n/resources/ru/jobs.js | Adds EntitiesDeleteJob label. |
| core/i18n/resources/ru/common.js | Capitalizes deleteExistingEntities option label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.