survey import: added chunk size dropdown (sysadmin only)#4160
Merged
survey import: added chunk size dropdown (sysadmin only)#4160
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a sysadmin-only dropdown to control file upload chunk size during survey import flows, and hardens the existing Arena data import chunk-size dropdown against “clear selection” null values.
Changes:
- Disable clearing on the Arena data import chunk-size dropdown to avoid null selections.
- Add a sysadmin-only chunk-size dropdown to Survey Create import, and pass the chosen chunk size into the import start function.
- Minor refactor/reordering in
Dropdownprops/propTypes and add styling for the new dropdown width.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| webapp/views/App/views/Data/DataImport/DataImportArenaView.js | Prevents clearing the chunk-size dropdown (avoids null selection path). |
| webapp/components/survey/SurveyCreate/SurveyCreate.scss | Adds width styling for the new chunk size dropdown. |
| webapp/components/survey/SurveyCreate/SurveyCreate.js | Introduces sysadmin-only chunk-size selection and passes it into import start params. |
| webapp/components/survey/SurveyCreate/store/actions/useOnImport.js | Wires chunkSize through to FileProcessor. |
| webapp/components/form/Dropdown/Dropdown.js | Reorders minCharactersToAutocomplete prop handling (no functional change intended). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…github.com/openforis/arena into feat/survey-import-add-chunk-size-dropdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.