Skip to content

Update to use ogd-common 2.0 #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LswaN58 wants to merge 212 commits into
base: main
Choose a base branch
from
Open

Update to use ogd-common 2.0 #471

LswaN58 wants to merge 212 commits into from

Conversation

@LswaN58
Copy link
Member

@LswaN58 LswaN58 commented Nov 3, 2025

Resolves #245
Resolves #447
Resolves #246

LswaN58 added 30 commits December 2, 2024 15:42
@LswaN58
Add a table_type element to OGD table schema.
79feff2
@LswaN58
Merge branch 'master' into issue/245-update-to-use-ogd-common-2.0
ba6718b
@LswaN58
Merge branch 'main' into issue/245-update-to-use-ogd-common-2.0
237228f
@LswaN58
Update import paths for generator configs.
f23ab60
@LswaN58
Update Aqualab features to import Feature, rather than FeatureData.
955b9e2
@LswaN58
Update Bloom features to import Feature, rather than FeatureData.
509ca98
@LswaN58
Update VR game features to import Feature, rather than FeatureData.
ee57c4b
@LswaN58
Oops, should have included ICECUBE as VR game that now imports Feature.
a84fb8b
@LswaN58
Update Jo, Lakeland, and Headlines features to import Feature, rather…
acd359c 
… than FeatureData.
@LswaN58
Finally, set Shadowspect features to import Feature, rather than Feat…
624ce06 
…ureData.
@LswaN58
Now, make Aqualab, Bloom, Jo, and Lakeland features import Extractor,…
5195578 
… rather than Feature base class.
@LswaN58
Do the same for VR games.
b821914
@LswaN58
Do similar for Waves, Crystal, Magnet, Headlines, and Shipwrecks.
6030302
@LswaN58
Missed Magnet loader in last commit.
be5a5b4
@LswaN58
Huh, missed shipwrecks in last commit too. Also, do shadowspect.
e5109d1
@LswaN58
Make sure all Aqualab, Bloom, and Shipwrecks features inherit from Ex…
754a85e 
…tractor, not Feature.
@LswaN58
Make sure WAVES and LAKELAND features only inherit from Extractor.
95c0b6c
@LswaN58
Missed a couple in Waves due to not accounting for non-alphabetic cha…
9fb6f35 
…racters in name.
@LswaN58
Add init files for the configs and generators folders.
fb8cc35
@LswaN58
Update loaders to return extractors, not 'features'.
2658ee6
@LswaN58
Across all features that had comment blocks, replace use of Feature w…
119c93d 
…ith Extractor.
@LswaN58
Finally, starting with Aqualab and Bloom, set _updateFromFeature func…
d730bfa 
…tions to use Feature, not FeatureData.
@LswaN58
Do the same for the VR games.
1a5b4ab
@LswaN58
Now do for Jo, Lakeland, and Waves.
3872ada
@LswaN58
Update FeatureData -> Feature in Shipwrecks and Headlines.
11795a4
@LswaN58
And finally, do it for shadowspect.
956f16f
@LswaN58
For this branch, update ogd-common requirement.
085ddc1
@LswaN58
Update path to access JSON loading.
d323390
@LswaN58
Back in core, need to update name of function to reflect that we're u…
2b5292e 
…pdating from Feature object, not FeatureData object.
@LswaN58
In loader classes, use GeneratorCollectionConfig, in place of old Gam…
9d6e61d 
…eSchema.
LswaN58 added 26 commits September 5, 2025 01:26
@LswaN58
Replace FromFile override with an implementation of _loadDirectories.
0acc07d
@LswaN58
Update exec function to also use Load instead of FromFile.
ba9917b
@LswaN58
Fix up configs for core to also use the 'if not None else' idiom.
88dd1b2
@LswaN58
In Commands, use start_date as end_date, if no specific end_date is g…
cedaf06 
…iven.
@LswaN58
Fix for names of the built-in table schemas.
0157e58
@LswaN58
Merge branch 'main' into issue/245-update-to-use-ogd-common-2.0
e581703
@LswaN58
Missed a change from the merge.
c1344bf
@LswaN58
Merge branch 'main' into issue/245-update-to-use-ogd-common-2.0
56fd4f5
@LswaN58
Ok, on second look, these features need to be per-job as written. Wil…
45044b2 
…l need to look into it more later.
@LswaN58
Update how we call constructors of DataTableConfigs.
da73723
@LswaN58
Looks like we also needed updates to DataTableConfig c'tor calls in t…
3a86593 
…he exec module.
@LswaN58
Need to always ensure our 'to' time is end of day.
8f96b26
@LswaN58
Also, specify that the function for setting up the date range is a da…
b2b13fa 
…tetime range.
@LswaN58
FeatureManager needs to update how it calls the lines.
29248cb
@LswaN58
Move management of outerfaces from request to export manager.
1b34b04
@LswaN58
Move a static function to right section, and improve some clarity in …
04c9573 
…comments.
@LswaN58
Remove old Field Day-specific config defaults.
6c40f7b
@LswaN58
Just generally ignore any file with a common 'backup' extension.
6125477
@LswaN58
Add explicit closing of interfaces and outerfaces when we're done wit…
d8b1fa5 
…h exports.
@LswaN58
Clean up how ExportManager reports out its results.
deaa7df
@LswaN58
Smarter way of getting games folder.
755fb64
@LswaN58
Fix a typo in comment.
223eb45
@LswaN58
In generator collection, skip any file extension from the config name.
0fe029b
@LswaN58
Fix a bunch of Aqualab features from other branches that imported out…
8b83462 
…dated stuff.
@LswaN58
Fix for case where we could have outerfaces with None for connector.
86446ac
@LswaN58
Fix for VS code errors in search-and-replace.
2b2e6b6
@LswaN58 LswaN58 self-assigned this Nov 3, 2025
@LswaN58 LswaN58 linked an issue Nov 3, 2025 that may be closed by this pull request
Implement new functions in Schema subclasses #246
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LswaN58 LswaN58

Labels

None yet

Projects

None yet

Milestone

ogd-core 0.0.15 "Update OGD-common"

2 participants

@LswaN58