Skip to content

Handle API responses without nested JSON string-serialization #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LswaN58 wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Handle API responses without nested JSON string-serialization #127

LswaN58 wants to merge 18 commits into from

Conversation

@LswaN58
Copy link
Member

@LswaN58 LswaN58 commented Nov 26, 2025

resolves #125

@LswaN58 LswaN58 self-assigned this Nov 26, 2025
@LswaN58 LswaN58 linked an issue Nov 26, 2025 that may be closed by this pull request
Handle responses that don't double-serialize all nested elements within the response #125
Open
LswaN58 added 17 commits December 20, 2025 21:28
@LswaN58
Make sure is at least defined.
d85fe65
@LswaN58
On further thought, just make use of the ret_val we already defined.
ff01401
@LswaN58
Pull out logic for curl request, so we've got single point of failure…
416a3b7 
…/debug prints.
@LswaN58
Add a line to make sure we get a slash between the base URL and the e…
6c8c230 
…ndpoint.
@LswaN58
Make getGameFileInfoByMonth responsible for default year/month.
15b86a6
@LswaN58
Do similar for getGameUsageByMonth.
ddb3001
@LswaN58
Slightly tweak where the default values are set.
1b815a3
@LswaN58
Comment out API endpoint hasn't been implemented or used.
11a59c2
@LswaN58
Do similar for JS function to call endpoint.
275026d
@LswaN58
On further thought, don't give null as a default for endpoint functio…
616ead5 
…n, make users actually pass something.
@LswaN58
Some formatting tweaks as I try to narrow down the weird behavior wit…
ee7698b 
…h API calls.
@LswaN58
Add a couple more debug prints if render functions get called on null…
34e6556 
… inputs.
@LswaN58
Try to ensure we don't ever make call on null.
7a68429
@LswaN58
Move call inside the check for non-null.
863ddcf
@LswaN58
Move the lines to convert response to APIResponse into the utility AP…
b329f9a 
…IRequest function as well.
@LswaN58
Ignore cspell configs.
bd080a4
@LswaN58
If there's a bona fide error in API request, include it in the error …
341ab74 
…string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LswaN58 LswaN58

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle responses that don't double-serialize all nested elements within the response

2 participants

@LswaN58