fix: prevent concurrent gateway start calls (EADDRINUSE race condition)#1
Open
nyrosveil wants to merge 1 commit intoopenguardrails:mainfrom
Open
fix: prevent concurrent gateway start calls (EADDRINUSE race condition)#1nyrosveil wants to merge 1 commit intoopenguardrails:mainfrom
nyrosveil wants to merge 1 commit intoopenguardrails:mainfrom
Conversation
- Add isStarting flag to prevent multiple start() calls simultaneously - This fixes EADDRINUSE error when plugin is initialized multiple times - The gateway was being started twice in quick succession, causing port conflicts
Contributor
|
@nyrosveil Please update moltguard plugin to 6.6.x. The code repo has been moved to https://github.com/openguardrails/openguardrails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a race condition in the GatewayManager that causes EADDRINUSE errors when the MoltGuard plugin is initialized multiple times in quick succession.
Problem
When the plugin is loaded, it sometimes attempts to start the gateway twice simultaneously:
Solution
Add an isStarting flag to prevent concurrent start() calls:
Changes
Testing
The fix has been tested locally and prevents the EADDRINUSE error when the plugin is initialized multiple times.