Skip to content

Comments

Updated ASP.NET Core examples to use Top Level Statements#383

Merged
kevinchalet merged 14 commits intoopeniddict:devfrom
m3nax:top-level-statement
Jan 29, 2026
Merged

Updated ASP.NET Core examples to use Top Level Statements#383
kevinchalet merged 14 commits intoopeniddict:devfrom
m3nax:top-level-statement

Conversation

@m3nax
Copy link
Contributor

@m3nax m3nax commented Jan 29, 2026

While studying the examples, I modified the initialization of the various services to use Top Level Statements to be more similar to the current Microsoft documentation for ASP.NET Core.

Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @m3nax,

Thanks for your PR: great initiative! 👏🏻

Note: the console, WPF and WinForms client samples could also benefit from some "minimal host" love, but while dapplo/Dapplo.Microsoft.Extensions.Hosting#53 was recently merged, no stable version including the necessary APIs has been released on NuGet yet. I'll keep an eye on future updates and revamp the samples so they are consistent with the ones you've converted as part of this PR.

Cheers.

@m3nax
Copy link
Contributor Author

m3nax commented Jan 29, 2026

Hey @m3nax,

Thanks for your PR: great initiative! 👏🏻

Note: the console, WPF and WinForms client samples could also benefit from some "minimal host" love, but while dapplo/Dapplo.Microsoft.Extensions.Hosting#53 was recently merged, no stable version including the necessary APIs has been released on NuGet yet. I'll keep an eye on future updates and revamp the samples so they are consistent with the ones you've converted as part of this PR.

Cheers.

Thank you for taking the time to review my pr

@kevinchalet kevinchalet merged commit cc9630c into openiddict:dev Jan 29, 2026
3 checks passed
@kevinchalet
Copy link
Member

Merged. Congrats for your first contribution to OpenIddict 👏🏻 🎉

@m3nax m3nax deleted the top-level-statement branch January 29, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants