refactor: replace i18next with lightweight custom i18n in core library #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove i18next dependency from core library (still used by website) - Add custom i18n implementation (~60 lines vs ~40KB) - Reduce minified bundle size by 40KB (-13%)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core library only needs basic translation support for error messages and warnings in English and German. This PR replaces i18next (40+ KB) with a minimal custom implementation (~60 lines).
Benefits:
opening_hours.js(without +deps) no longer need to include i18nextCompatibility:
Note: i18next remains in dependencies for the web evaluation tool which supports 12 languages.