Skip to content

8362834: Several runtime/Thread tests should mark as /native #26411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 21, 2025

Hi all,

Some of the runtime/Thread tests ready mark as /native:
runtime/Thread/SuspendAtExit.java
runtime/Thread/StopAtExit.java

But there are some of the runtime/Thread tests needed to mark as /native:
runtime/Thread/AsyncExceptionTest.java
runtime/Thread/AsyncExceptionOnMonitorEnter.java
runtime/Thread/TestBreakSignalThreadDump.java#with_jsig
runtime/Thread/TestBreakSignalThreadDump.java#default

Without -nativepath jtreg option, the test will report test failure, such as: "Execution failed: `main' threw exception: java.lang.RuntimeException: Expected to get exit value of [0], exit value is: [1]", after this PR without -nativepath jtreg option, the test will report "Error. Use -nativepath to specify the location of native code", this will make test usage more friendly.

Change has been verified locally, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362834: Several runtime/Thread tests should mark as /native (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26411/head:pull/26411
$ git checkout pull/26411

Update a local copy of the PR:
$ git checkout pull/26411
$ git pull https://git.openjdk.org/jdk.git pull/26411/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26411

View PR using the GUI difftool:
$ git pr show -t 26411

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26411.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362834: Several runtime/Thread tests should mark as /native

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 21, 2025
@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 21, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

FWIW I always use a jtreg wrapper that sets the -nativepath no matter what test I'm running.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2025
@sendaoYan
Copy link
Member Author

Thanks @dholmes-ora

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

Going to push as commit 699b811.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 22, 2025
@openjdk openjdk bot closed this Jul 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2025
@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@sendaoYan Pushed as commit 699b811.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants