Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 10, 2025

A simple fix for off-by-one error in parsing smaps -- the final mapping is never recorded as we exits the parsing loop too early.

Test: tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371587: Final mapping lost in ProcSmapsParser::parse_next (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28225/head:pull/28225
$ git checkout pull/28225

Update a local copy of the PR:
$ git checkout pull/28225
$ git pull https://git.openjdk.org/jdk.git pull/28225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28225

View PR using the GUI difftool:
$ git pr show -t 28225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28225.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8371587 8371587: Final mapping lost in ProcSmapsParser::parse_next Nov 10, 2025
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant