Skip to content

Conversation

@wenshao
Copy link
Contributor

@wenshao wenshao commented Nov 11, 2025

The purpose of this draft PR is to explore merging two consecutive StringBuilder.append(char) calls into append(char, char) in the C2 optimizer, reducing one ensureCapacity call and triggering more optimizations, such as MergeStore.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Error

 ⚠️ Could not determine the source for this merge. A Merge PR title must be specified in the format: ^Merge ([-/.\w:+]+)$ to allow verification of the merge contents.

Integration blocker

 ⚠️ Dependency #26911 must be integrated first

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28228/head:pull/28228
$ git checkout pull/28228

Update a local copy of the PR:
$ git checkout pull/28228
$ git pull https://git.openjdk.org/jdk.git pull/28228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28228

View PR using the GUI difftool:
$ git pr show -t 28228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28228.diff

@wenshao wenshao changed the title Append pair 202508 c2 2025 11 11 1731 This merges two StringBuilder.append(char) calls into a single append(char, char) call Nov 11, 2025
@wenshao wenshao changed the title This merges two StringBuilder.append(char) calls into a single append(char, char) call Merges two StringBuilder.append(char) calls into a single append(char, char) call Nov 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back swen! A progress list of the required criteria for merging this PR into pr/26911 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added clean Identical backport; no merge resolution required security security-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@wenshao The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean Identical backport; no merge resolution required core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant