Skip to content

8326498: java.net.http.HttpClient connection leak using http/2 #28233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+845 −266
Open

8326498: java.net.http.HttpClient connection leak using http/2 #28233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abb9cb8
8326498: java.net.http.HttpClient connection leak using http/2
jaikiran Jul 8, 2025
b8e2866
introduce a test to reproduce the leak and verify the fix
jaikiran Nov 2, 2025
88c6bbc
Daniel's review suggestion - stop the scheduler when TubeSubscriber e…
jaikiran Nov 4, 2025
4cf52bb
Return false from isOpen() if underlying channel is not open
jaikiran Nov 6, 2025
392f694
update test
jaikiran Nov 11, 2025
6c98302
cleanup
jaikiran Nov 11, 2025
1a70acc
reduce number of concurrent requests
jaikiran Nov 11, 2025
3e4574b
mark jdk.internal.net.http.Http2Connection as Closable
jaikiran Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import java.time.Duration;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Executor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;
Expand Down Expand Up @@ -708,12 +707,12 @@ HttpResponse.BodySubscriber<T> ignoreBody(HttpResponse.ResponseInfo hdrs) {
if (s == null) {
// s can be null if an exception occurred
// asynchronously while sending the preface.
Throwable t = c.getRecordedCause();
final Throwable terminationException = c.getTerminationException()
.orElse(null);
IOException ioe;
if (t != null) {
if (!cached)
c.close();
Comment on lines -714 to -715
Copy link
Contributor

@vy vy Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We remove the if (!cached) c.close() logic. Where do we restore this functionality? If not, why not?

Copy link
Member

@dfuch dfuch Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the terminationException is not null the connection is already closed (or being closed by another thread) so there's no need to call close() again.

ioe = new IOException("Can't get stream 1: " + t, t);
if (terminationException != null) {
ioe = new IOException("Can't get stream 1: " + terminationException,
terminationException);
} else {
ioe = new IOException("Can't get stream 1");
}
Expand Down
9 changes: 1 addition & 8 deletions src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -25,7 +25,6 @@

package jdk.internal.net.http;

import java.io.EOFException;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.util.Base64;
Expand Down Expand Up @@ -234,11 +233,8 @@ void removeFromPool(Http2Connection c) {
}
}

private EOFException STOPPED;
void stop() {
if (debug.on()) debug.log("stopping");
STOPPED = new EOFException("HTTP/2 client stopped");
STOPPED.setStackTrace(new StackTraceElement[0]);
connectionPoolLock.lock();
try {
stopping = true;
Expand All @@ -253,10 +249,7 @@ void stop() {
private boolean close(Http2Connection h2c) {
// close all streams
try { h2c.closeAllStreams(); } catch (Throwable t) {}
// send GOAWAY
try { h2c.close(); } catch (Throwable t) {}
// attempt graceful shutdown
try { h2c.shutdown(STOPPED); } catch (Throwable t) {}
// double check and close any new streams
try { h2c.closeAllStreams(); } catch (Throwable t) {}
// Allows for use of removeIf in stop()
Expand Down
Loading