Skip to content

Conversation

@rgangadhar
Copy link
Member

@rgangadhar rgangadhar commented Nov 11, 2025

Very Trivial Changing in JceSecurity.java.template

Changed from UNLIMTED_CRYPTO to
UNLIMITED_CRYPTO


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357874: UNLIMTED_CRYPTO typo in class description of JceSecurity.java.template (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28238/head:pull/28238
$ git checkout pull/28238

Update a local copy of the PR:
$ git checkout pull/28238
$ git pull https://git.openjdk.org/jdk.git pull/28238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28238

View PR using the GUI difftool:
$ git pr show -t 28238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28238.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back rgangadhar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@rgangadhar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357874: UNLIMTED_CRYPTO typo in class description of JceSecurity.java.template

Reviewed-by: wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bradfordwetmore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 8357874: UNLIMTED_CRYPTO typo in class description of JceSecurity.jav… 8357874: UNLIMTED_CRYPTO typo in class description of JceSecurity.java.template Nov 11, 2025
@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@rgangadhar The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2025
@rgangadhar
Copy link
Member Author

@seanjmullan : pls review this PR

@mlbridge
Copy link

mlbridge bot commented Nov 11, 2025

Webrevs

Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's kind of embarrassing. ;) Good catch.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 13, 2025
@rgangadhar
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@rgangadhar
Your change (at version a86d766) is now ready to be sponsored by a Committer.

@rgangadhar
Copy link
Member Author

@bradfordwetmore / @seanjmullan pls sponsor

@seanjmullan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

Going to push as commit 6b6fdf1.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 13, 2025
@openjdk openjdk bot closed this Nov 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@seanjmullan @rgangadhar Pushed as commit 6b6fdf1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants