Skip to content

8371381: [Shenandoah] Setting ergo flags should use FLAG_SET_ERGO #28242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8371381: [Shenandoah] Setting ergo flags should use FLAG_SET_ERGO #28242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a5a09b
8371381: [Shenandoah] Setting ergo flags should use FLAG_SET_ERGO
rgithubli Nov 7, 2025
65fc987
Use FLAG_SET_DEFAULT for ShenandoahEvacReserve in passive
rgithubli Nov 12, 2025
6200456
Move ShenandoahEvacReserve back to (1,100)
rgithubli Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,23 +36,23 @@
do { \
if (FLAG_IS_DEFAULT(name) && (name)) { \
log_info(gc)("Heuristics ergonomically sets -XX:-" #name); \
FLAG_SET_DEFAULT(name, false); \
FLAG_SET_ERGO(name, false); \
} \
} while (0)

#define SHENANDOAH_ERGO_ENABLE_FLAG(name) \
do { \
if (FLAG_IS_DEFAULT(name) && !(name)) { \
log_info(gc)("Heuristics ergonomically sets -XX:+" #name); \
FLAG_SET_DEFAULT(name, true); \
FLAG_SET_ERGO(name, true); \
} \
} while (0)

#define SHENANDOAH_ERGO_OVERRIDE_DEFAULT(name, value) \
do { \
if (FLAG_IS_DEFAULT(name)) { \
log_info(gc)("Heuristics ergonomically sets -XX:" #name "=" #value); \
FLAG_SET_DEFAULT(name, value); \
FLAG_SET_ERGO(name, value); \
} \
} while (0)

Expand Down
6 changes: 5 additions & 1 deletion src/hotspot/share/gc/shenandoah/mode/shenandoahPassiveMode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "gc/shenandoah/shenandoahHeap.inline.hpp"
#include "logging/log.hpp"
#include "logging/logTag.hpp"
#include "runtime/globals_extension.hpp"
#include "runtime/java.hpp"

void ShenandoahPassiveMode::initialize_flags() const {
Expand All @@ -38,7 +39,10 @@ void ShenandoahPassiveMode::initialize_flags() const {

// No need for evacuation reserve with Full GC, only for Degenerated GC.
if (!ShenandoahDegeneratedGC) {
SHENANDOAH_ERGO_OVERRIDE_DEFAULT(ShenandoahEvacReserve, 0);
if (FLAG_IS_DEFAULT(ShenandoahEvacReserve)) {
log_info(gc)("Heuristics sets -XX:ShenandoahEvacReserve=0");
FLAG_SET_DEFAULT(ShenandoahEvacReserve, 0);
}
}

// Disable known barriers by default.
Expand Down