Skip to content

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Nov 13, 2025

Backport of JDK-8368192 that fixes this test, that started failing on GHA/macos-15 after JDK-8369226

This PR is on top of #3117, to verify the test passes.

Backport is not clean as the @Bug entries are different from 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8368192 needs maintainer approval

Integration blocker

 ⚠️ Dependency #3117 must be integrated first

Issue

  • JDK-8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception: Stack trace (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3119/head:pull/3119
$ git checkout pull/3119

Update a local copy of the PR:
$ git checkout pull/3119
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3119

View PR using the GUI difftool:
$ git pr show -t 3119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3119.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into pr/3117 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2b5b97b3cc44b34f1d3d2f2e9fd2fa545d769e3b 8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception: Stack trace Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@vieiro vieiro mentioned this pull request Nov 14, 2025
4 tasks
@vieiro
Copy link
Contributor Author

vieiro commented Nov 14, 2025

Some tests failed because .local DNS resolution failures, so let's re-run the tests on top of JDK-8336451 in #3117.

All tests should be green now.

@vieiro vieiro force-pushed the backports/JDK-8368192-2 branch from 6a0c570 to 0c74f86 Compare November 14, 2025 13:38
@vieiro
Copy link
Contributor Author

vieiro commented Nov 14, 2025

Rebasing on top of oupdated #3117

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@vieiro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@vieiro vieiro marked this pull request as draft November 18, 2025 15:58
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base

Development

Successfully merging this pull request may close these issues.

1 participant