Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Nov 11, 2025

Backporting JDK-8368328: CompactNumberFormat.clone does not produce independent instances. Fixes clone method logic and adds a new test. Ran GHA Sanity Checks (passed) and new test (passed). Patch is clean.


Progress

  • JDK-8368328 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368328: CompactNumberFormat.clone does not produce independent instances (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4168/head:pull/4168
$ git checkout pull/4168

Update a local copy of the PR:
$ git checkout pull/4168
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4168

View PR using the GUI difftool:
$ git pr show -t 4168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4168.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bdf6853cfdd24176bdddb59b6d7bb85036b94c57 8368328: CompactNumberFormat.clone does not produce independent instances Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 11, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review November 12, 2025 19:20
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

@j3graham
Copy link

It might be worth considering a backport of JDK-8354522 (Clones of DecimalFormat cause interferences when used) together with this. The fix for CompactNumberFormat.clone relies on DecimalFormat.clone which also had issues before this other fix.

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 12, 2025

/approval request for backport of JDK-8368328: CompactNumberFormat.clone does not produce independent instances.

Ran the new test on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/text/Format/CompactNumberFormat/TestClone.java

Results are attached.
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@rm-gh-8
8368328: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants