-
Notifications
You must be signed in to change notification settings - Fork 232
8368328: CompactNumberFormat.clone does not produce independent instances #4168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
It might be worth considering a backport of JDK-8354522 (Clones of DecimalFormat cause interferences when used) together with this. The fix for CompactNumberFormat.clone relies on DecimalFormat.clone which also had issues before this other fix. |
|
/approval request for backport of JDK-8368328: CompactNumberFormat.clone does not produce independent instances. Ran the new test on linux-x64, linux-aarch64, macos-aarch64 and windows-x64: (All Passed) - make test TEST=test/jdk/java/text/Format/CompactNumberFormat/TestClone.java Results are attached. |
Backporting JDK-8368328: CompactNumberFormat.clone does not produce independent instances. Fixes clone method logic and adds a new test. Ran GHA Sanity Checks (passed) and new test (passed). Patch is clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4168/head:pull/4168$ git checkout pull/4168Update a local copy of the PR:
$ git checkout pull/4168$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4168/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4168View PR using the GUI difftool:
$ git pr show -t 4168Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4168.diff
Using Webrev
Link to Webrev Comment