Skip to content

Conversation

@mmm-choi
Copy link
Contributor

@mmm-choi mmm-choi commented Nov 12, 2025

Clean backport, removes unused notproduct flag TraceInvocationCounterOverflow that has no references in the codebase.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327290 needs maintainer approval

Issue

  • JDK-8327290: Remove unused notproduct option TraceInvocationCounterOverflow (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4176/head:pull/4176
$ git checkout pull/4176

Update a local copy of the PR:
$ git checkout pull/4176
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4176

View PR using the GUI difftool:
$ git pr show -t 4176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4176.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back mmm-choi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7157eea10130e5411ab8db4273dc37f6789cdcf6 8327290: Remove unused notproduct option TraceInvocationCounterOverflow Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 12, 2025
@mmm-choi mmm-choi marked this pull request as ready for review November 13, 2025 00:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant