8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E

[satyenme]

Backporting JDK-8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E. Adding stability fixes to bug6884066.java test. Ran GHA Sanity Checks and adjusted test directly. Patch is clean. Backporting for parity with Oracle.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8305778 needs maintainer approval

Issue

• JDK-8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4178/head:pull/4178
$ git checkout pull/4178

Update a local copy of the PR:
$ git checkout pull/4178
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4178

View PR using the GUI difftool:
$ git pr show -t 4178

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4178.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 23ee787: 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark
• fadb26f: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
• 22fef0a: 8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/9bf2571e7bc9d8752e0c10fcde4973df2f7688ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (8720841a)

[satyenme]

/approval request for backport of JDK-8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E

Motivation: With this change, we update test code to be more robust and match upstream. Only touches test code logic of a single test without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks and adjusted test. Patch is clean. Change has only been present in tip since April, 2023, change has been accepted by Oracle.

[openjdk]

@satyenme
8305778: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

Going to push as commit cb258e5.
Since your change was applied there have been 10 commits pushed to the master branch:

• 1f14254: 8353661: Open source several swing tests batch5
• c618617: 8303959: tools/jpackage/share/RuntimePackageTest.java fails with java.lang.AssertionError missing files
• 23ee787: 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark
• ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/9bf2571e7bc9d8752e0c10fcde4973df2f7688ea...master

Your commit was automatically rebased without conflicts.

[openjdk]

@satyenme Pushed as commit cb258e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.