Skip to content

Conversation

@jmtd
Copy link

@jmtd jmtd commented Nov 7, 2025

This is a trivial test only fix to backport for oracle parity.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366128 needs maintainer approval

Issue

  • JDK-8366128: jdk/jdk/nio/zipfs/TestPosix.java::testJarFile uses wrong file (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2453/head:pull/2453
$ git checkout pull/2453

Update a local copy of the PR:
$ git checkout pull/2453
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2453

View PR using the GUI difftool:
$ git pr show -t 2453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2453.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 22d3a6dd34a14994c7210365a5b982c9e65f5892 8366128: jdk/jdk/nio/zipfs/TestPosix.java::testJarFile uses wrong file Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

⚠️ @jmtd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

@jmtd
Copy link
Author

jmtd commented Nov 7, 2025

Not requesting approval until 25 is resolved. 25 PR: openjdk/jdk25u#365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant