Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Nov 11, 2025

Backporting JDK-8317678: Fix up hashCode() for ZipFile.Source.Key. Fixes the hashCode implementation and adds a new benchmark test. Ran GHA Sanity Checks (passed), related zip tests and new benchmark test (passed). Patch is clean..


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317678 needs maintainer approval

Issue

  • JDK-8317678: Fix up hashCode() for ZipFile.Source.Key (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2463/head:pull/2463
$ git checkout pull/2463

Update a local copy of the PR:
$ git checkout pull/2463
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2463

View PR using the GUI difftool:
$ git pr show -t 2463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2463.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8d9a4b43f4fff30fd217dab2c224e641cb913c18 8317678: Fix up hashCode() for ZipFile.Source.Key Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 11, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review November 12, 2025 15:51
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 12, 2025

/approval request for backport of JDK-8317678: Fix up hashCode() for ZipFile.Source.Key.

Ran the related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/util/Calendar

Ran the new benchmark tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Successful) java -jar build/*/images/test/micro/benchmarks.jar java.util.zip.ZipFileOpen

Results are attached.
linux-aarch64-microbench-test.log
linux-aarch64-specific-test.log
linux-x64-microbench-test.log
linux-x64-specific-test.log
macos-aarch64-microbench-test.log
macos-aarch64-specific-test.log
windows-x64-microbench-test.log
windows-x64-specific-test.log

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@rm-gh-8
8317678: The approval request has been updated successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant