-
Notifications
You must be signed in to change notification settings - Fork 148
8317678: Fix up hashCode() for ZipFile.Source.Key #2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8317678: Fix up hashCode() for ZipFile.Source.Key. Ran the related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64: (All Passed) - make test TEST=test/jdk/java/util/Calendar Ran the new benchmark tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64: (Successful) java -jar build/*/images/test/micro/benchmarks.jar java.util.zip.ZipFileOpen Results are attached. |
Backporting JDK-8317678: Fix up hashCode() for ZipFile.Source.Key. Fixes the hashCode implementation and adds a new benchmark test. Ran GHA Sanity Checks (passed), related zip tests and new benchmark test (passed). Patch is clean..
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2463/head:pull/2463$ git checkout pull/2463Update a local copy of the PR:
$ git checkout pull/2463$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2463/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2463View PR using the GUI difftool:
$ git pr show -t 2463Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2463.diff
Using Webrev
Link to Webrev Comment