8358496: Concurrent reading from Socket with timeout executes sequentially

[rm-gh-8]

Backporting JDK-8358496: Concurrent reading from Socket with timeout executes sequentially. Updated SocketImpl so that the timeout applies to the total time waiting to acquire and read. Adds a new test to the existing java/net/Socket/Timeouts test. The test was minimally modified from the original commit for JDK version compatibility.

Ran GHA Sanity Checks (passed) and related test (passed).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8358496 needs maintainer approval

Issue

• JDK-8358496: Concurrent reading from Socket with timeout executes sequentially (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2470/head:pull/2470
$ git checkout pull/2470

Update a local copy of the PR:
$ git checkout pull/2470
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2470/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2470

View PR using the GUI difftool:
$ git pr show -t 2470

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2470.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e2b88838)

[rm-gh-8]

/approval request for backport of JDK-8358496: Concurrent reading from Socket with timeout executes sequentially.

Ran the updated and related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/net/Socket

Results are attached.
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

[openjdk]

@rm-gh-8
8358496: The approval request has been created successfully.

[phohensee]

The only conflict I see is in Timeouts.java where the original commit deleted the import of ScheduledExecutorService. You can probably fix that.

[rm-gh-8]

The ScheduledExecutorService class was re-introduced because the ForkJoinPool class doesn't support the schedule method in JDK 21. It was refactored to use the previous implementation for compatibility.

ForkJoinPool.commonPool().schedule(task, delay, TimeUnit.MILLISECONDS)