Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Nov 13, 2025

Backporting JDK-8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions. JPEG segments have a 65535-byte limit, but the code was writing larger segments, causing parsing errors when reading files back.

Two fixes implemented:

  1. Constrains thumbnail dimensions to fit within the segment limit.

  2. Added safety check to write2bytes that throws IIOException if segment size is exceeded.

Ran GHA Sanity Checks (passed) and related test (passed).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8351110 needs maintainer approval

Issue

  • JDK-8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2471/head:pull/2471
$ git checkout pull/2471

Update a local copy of the PR:
$ git checkout pull/2471
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2471

View PR using the GUI difftool:
$ git pr show -t 2471

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2471.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 60f3d607412dfe289f33dd922dfc1c9ff766810f 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 13, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review November 13, 2025 23:32
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 14, 2025

/approval request for backport of JDK-8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions.

Ran the updated and related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/javax/imageio/plugins/jpeg

Results are attached.
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@rm-gh-8
8351110: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant