8321156: Improve the handling of invalid UTF-8 byte sequences for ZipInputStream::getNextEntry and ZipFile::getComment #2480
+270
−112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8321156: Improve the handling of invalid UTF-8 byte sequences for ZipInputStream::getNextEntry and ZipFile::getComment.
Fixes invalid UTF-8 byte sequence handling in:
Behavior change: ZipFile::getComment now returns null when invalid UTF-8 sequences are detected during byte-to-String conversion.
Ran GHA Sanity Checks (passed) and related test (passed).
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2480/head:pull/2480$ git checkout pull/2480Update a local copy of the PR:
$ git checkout pull/2480$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2480/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2480View PR using the GUI difftool:
$ git pr show -t 2480Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2480.diff
Using Webrev
Link to Webrev Comment