-
Notifications
You must be signed in to change notification settings - Fork 111
8371425: Include folder names in vscode workspace virtual folders #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back krk! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
Webrevs
|
|
/approval request Improve VSCode workspace folder naming to distinguish multiple instances and build configs. no impact to product. |
Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from
make vscode-project.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/368/head:pull/368$ git checkout pull/368Update a local copy of the PR:
$ git checkout pull/368$ git pull https://git.openjdk.org/jdk25u.git pull/368/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 368View PR using the GUI difftool:
$ git pr show -t 368Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/368.diff
Using Webrev
Link to Webrev Comment