8370242: JFR: Clear event reference eagerly when using EventStream

[egahlin]

Could I have review of a clean backport?

Testing: tier1 + test/jdk/dk/jfr

Thanks
Erik

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8370242 needs maintainer approval

Issue

• JDK-8370242: JFR: Clear event reference eagerly when using EventStream (Bug - P3 - Approved)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/372/head:pull/372
$ git checkout pull/372

Update a local copy of the PR:
$ git checkout pull/372
$ git pull https://git.openjdk.org/jdk25u.git pull/372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 372

View PR using the GUI difftool:
$ git pr show -t 372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/372.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370242: JFR: Clear event reference eagerly when using EventStream

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 6a410a8: 8372320: Bump update version for OpenJDK: jdk-25.0.3
• 8fd9a73: 8371094: --mac-signing-key-user-name no longer works
• 816cfbf: 8370318: AES-GCM vector intrinsic may read out of bounds (x86_64, AVX-512)
• ... and 1 more: https://git.openjdk.org/jdk25u/compare/89c5659aa88acd1e9624aa14e5b9757255e55916...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @egahlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (752f9363)

[egahlin]

/label add hotspot-jfr

[openjdk]

@egahlin
The label hotspot-jfr is not a valid label.
These labels are valid:

[GoeLin]

Hi @egahlin,
are you aware of the failed GHA test?

[egahlin]

Hi @egahlin, are you aware of the failed GHA test?

I noticed that ClassVersionAfterRedefine.java failed on linux static, but I can't see how it relates to this Java only change in the jdk.jfr module. The test passes on other platforms, so my assumption was an intermittent error not related to this change.

[GoeLin]

Thanks!

[egahlin]

/integrate

[openjdk]

Going to push as commit 5c9150f.
Since your change was applied there have been 7 commits pushed to the master branch:

• 796f2b4: 8371425: Include folder names in vscode workspace virtual folders
• da10b6d: 8371697: test/jdk/java/nio/file/FileStore/Basic.java fails after 8360887 on linux
• 95f4bc9: 8368982: Test sun/security/tools/jarsigner/EC.java completed and timed out
• ... and 4 more: https://git.openjdk.org/jdk25u/compare/89c5659aa88acd1e9624aa14e5b9757255e55916...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 5c9150f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.