Skip to content

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Nov 12, 2025

Can I have a review of a clean backport?

Testing: tier1 + test/jdk/dk/jfr

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365972 needs maintainer approval

Issue

  • JDK-8365972: JFR: ThreadDump and ClassLoaderStatistics events may cause back to back rotations (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/373/head:pull/373
$ git checkout pull/373

Update a local copy of the PR:
$ git checkout pull/373
$ git pull https://git.openjdk.org/jdk25u.git pull/373/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 373

View PR using the GUI difftool:
$ git pr show -t 373

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/373.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 681dab7205190176b842bd42914b1cb9fe752e44 8365972: JFR: ThreadDump and ClassLoaderStatistics events may cause back to back rotations Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 12, 2025
@egahlin egahlin marked this pull request as ready for review November 13, 2025 17:00
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

⚠️ @egahlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@egahlin This pull request has not yet been marked as ready for integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants