Skip to content

Conversation

@psoujany
Copy link

@psoujany psoujany commented Nov 12, 2025

This PR is a backport of openjdk/jdk#26737


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365305 needs maintainer approval

Issue

  • JDK-8365305: The ARIA role ‘contentinfo’ is not valid for the element <footer> (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/374/head:pull/374
$ git checkout pull/374

Update a local copy of the PR:
$ git checkout pull/374
$ git pull https://git.openjdk.org/jdk25u.git pull/374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 374

View PR using the GUI difftool:
$ git pr show -t 374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/374.diff

Using Webrev

Link to Webrev Comment

Signed-off-by: Pasam Soujanya <psoujany@in.ibm.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back psoujany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

⚠️ @psoujany the commit f1fcacdf990bfe715ed6c322643c12a4d5226b06 does not refer to an issue in project JDK.

@psoujany psoujany changed the title Backport f1fcacdf990bfe715ed6c322643c12a4d5226b06 8365305: The ARIA role ‘contentinfo’ is not valid for the element <footer> Nov 12, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

@psoujany
Copy link
Author

psoujany commented Nov 13, 2025

Fix Request : https://bugs.openjdk.org/browse/JDK-8365305 request clean backport, The ARIA role ‘contentinfo’ is not valid for the element <footer> in jdk21u-fix-request.

@psoujany
Copy link
Author

@hns Could you please check on this backport. Thank you.

@hns
Copy link
Member

hns commented Nov 26, 2025

Please set the PR title to "Backport 6e91ccd1c3926094a9b6d8f9177d895aba3424a1" to make Skara recognize this as a backport PR.

This is documented here: https://wiki.openjdk.org/display/SKARA/Backports#Backports-BackportPullRequests

@psoujany psoujany changed the title 8365305: The ARIA role ‘contentinfo’ is not valid for the element <footer> Backport 6e91ccd1c3926094a9b6d8f9177d895aba3424a1 Nov 27, 2025
@openjdk openjdk bot changed the title Backport 6e91ccd1c3926094a9b6d8f9177d895aba3424a1 8365305: The ARIA role ‘contentinfo’ is not valid for the element <footer> Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

⚠️ @psoujany This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@psoujany
Copy link
Author

/approval request for backport of JDK-8365305 which removes role=contentinfo for the footer element. Low risk as it is clean backport.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@psoujany
8365305: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants