8366278: Form control element <select> has no associated label

[psoujany]

This PR is a backport of https://bugs.openjdk.org/browse/JDK-8366278

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8366278 needs maintainer approval

Issue

• JDK-8366278: Form control element <select> has no associated label (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/375/head:pull/375
$ git checkout pull/375

Update a local copy of the PR:
$ git checkout pull/375
$ git pull https://git.openjdk.org/jdk25u.git pull/375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 375

View PR using the GUI difftool:
$ git pr show -t 375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/375.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psoujany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (d661937b)

[psoujany]

Fix Request : https://bugs.openjdk.org/browse/JDK-8366278 request clean backport, Form control element <select> has no associated label in jdk21u-fix-request

[psoujany]

@hns Could you please check on this backport. Thank you.

[hns]

The change looks good, but the issue is marked as fixed in 25. If this is by mistake, it should be fixed before doing the backport. Also, there are some rules regarding backporting that must be followed, including getting approval for a backport by the maintainer.

[psoujany]

I mistakenly set version to 25. Thank you for clarifying @hns

[hns]

The "Issue" section above explains how to make this a backport pull request by setting the PR title to "Backport [hash]" where [hash] is the hash of the original commit in the main repository.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @psoujany This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[psoujany]

/approval request for backport of JDK-8366278 adds ARIA_LABEL to form control element. Low risk as this is clean backport.

[openjdk]

@psoujany
8366278: The approval request has been created successfully.

[GoeLin]

Hi @psoujany
the fact that this is clean is not an indication of a low risk.
You must consider the effects on an existing application that get's an update of its jdk with your change.
What is the risk for this application? Imagine a clean backport of a change that changes the default GC. This can have a huge impact on an application.

[psoujany]

Hi @GoeLin , the fix is related to accessibility. We tested the fix with JDK25 and didn't find any regressions, so this could be of low risk. Could you please let me know if anything needs to be validated for this backport. Thank you.

[GoeLin]

Hi @psoujany,
The new risk assessment makes sense, thanks.
Please enable the GHA tests on your repo.
If these have passed, please issue the approval command again, giving a more comprehensive comment including the risk assessment. It will update the comment in the JBS issue.