8370405: C2: mismatched store from MergeStores wrongly scalarized in allocation elimination #382
+375
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JDK 21 -> JDK 25 regression in C2 that can lead to miscompilation. There is a regression test that captures the failure.
Additional testing:
allProgress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/382/head:pull/382$ git checkout pull/382Update a local copy of the PR:
$ git checkout pull/382$ git pull https://git.openjdk.org/jdk25u.git pull/382/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 382View PR using the GUI difftool:
$ git pr show -t 382Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/382.diff
Using Webrev
Link to Webrev Comment