Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Nov 19, 2025

Fixes JDK 21 -> JDK 25 regression in C2 that can lead to miscompilation. There is a regression test that captures the failure.

Additional testing:

  • Linux x86_64 server fastdebug, new regression test fails without the fix, passes with it
  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8370405 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8371385 needs maintainer approval

Issues

  • JDK-8370405: C2: mismatched store from MergeStores wrongly scalarized in allocation elimination (Bug - P3)
  • JDK-8371385: compiler/escapeAnalysis/TestRematerializeObjects.java fails in case of -XX:-UseUnalignedAccesses (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/382/head:pull/382
$ git checkout pull/382

Update a local copy of the PR:
$ git checkout pull/382
$ git pull https://git.openjdk.org/jdk25u.git pull/382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 382

View PR using the GUI difftool:
$ git pr show -t 382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/382.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 09a047f00c88d14505c42a966dedbc87b9be5bdf 8370405: C2: mismatched store from MergeStores wrongly scalarized in allocation elimination Nov 19, 2025
@openjdk
Copy link

openjdk bot commented Nov 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 19, 2025
@openjdk
Copy link

openjdk bot commented Nov 19, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2025

Webrevs

@shipilev
Copy link
Member Author

/issue add JDK-8371385

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Nov 20, 2025
@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@shipilev
Adding additional issue to issue list: 8371385: compiler/escapeAnalysis/TestRematerializeObjects.java fails in case of -XX:-UseUnalignedAccesses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant