Skip to content

Conversation

@vish-chan
Copy link

@vish-chan vish-chan commented Nov 21, 2025

Backport of:

  • JDK-8361363 - ShenandoahAsserts::print_obj() does not work for forwarded objects and UseCompactObjectHeaders
  • This change fixes Shenandoah’s print_obj() so it correctly prints forwarded objects when compact object headers are enabled, instead of crashing by reading an invalid klass from the forwarding pointer.

Risk is Low as this is a clean backport and the changes are in diagnostic code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8361363 needs maintainer approval

Issue

  • JDK-8361363: ShenandoahAsserts::print_obj() does not work for forwarded objects and UseCompactObjectHeaders (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/384/head:pull/384
$ git checkout pull/384

Update a local copy of the PR:
$ git checkout pull/384
$ git pull https://git.openjdk.org/jdk25u.git pull/384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 384

View PR using the GUI difftool:
$ git pr show -t 384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/384.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back vish-chan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fe264676337cdef0d7477b0b57ff9d2fe8f9fc0f 8361363: ShenandoahAsserts::print_obj() does not work for forwarded objects and UseCompactObjectHeaders Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

⚠️ @vish-chan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2025

Webrevs

@vish-chan
Copy link
Author

vish-chan commented Nov 24, 2025

/approval request for backport of JDK-8361363 which fixes Shenandoah’s print_obj() so it correctly prints forwarded objects when compact object headers are enabled, instead of crashing by reading an invalid klass from the forwarding pointer.
Risk is Low as this is a clean backport and the changes are in diagnostic code.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@vish-chan
8361363: Can not be found in the JDK project.

@vish-chan
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@vish-chan The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant