Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 24, 2025

Hi all,

This backport PR partial fix the test bug, which may cause test fails without swapping memory. Change has been verified locally. Test-fix only, no risk. This backport will make later backport JDK-8343340 cleanly.

Only the different copyright year cause this backport uncleanly. Other parts are backport cleanly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8264524 needs maintainer approval

Issue

  • JDK-8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/708/head:pull/708
$ git checkout pull/708

Update a local copy of the PR:
$ git checkout pull/708
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 708

View PR using the GUI difftool:
$ git pr show -t 708

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/708.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bfb034abf9d5e5eb24d524f35b3f745e94631c4a 8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 24, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the reviews @phohensee

/approval request Backport to partial fix the test bug, and will make the later backport JDK-8343340 to jdk8u cleanly. Change has been verifiedlocally on linux-x64 which swapping memory is enable. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@sendaoYan
8264524: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants