-
Notifications
You must be signed in to change notification settings - Fork 173
8371387: [8u] hotspot needs to recognise latest VS2022 #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
|
@ktakakuri This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
|
|
/approval request The patch updates hotspot build scripts to recognize cl.exe versions 1939 through 1944 and link.exe versions 1439 through 1444 belonging to the MSVS2022 family. |
|
@ktakakuri |
|
@gnu-andrew I apologize for bothering you during your busy schedule, but could you please review the Fix Request? I would like to include this fix in the January release. |
This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412.
I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/714/head:pull/714$ git checkout pull/714Update a local copy of the PR:
$ git checkout pull/714$ git pull https://git.openjdk.org/jdk8u-dev.git pull/714/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 714View PR using the GUI difftool:
$ git pr show -t 714Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/714.diff
Using Webrev
Link to Webrev Comment