Skip to content

test(e2b): update E2B tests and patch_e2b#160

Open
yanghanlin wants to merge 3 commits intoopenkruise:masterfrom
yanghanlin:feature/e2b-test-improvements
Open

test(e2b): update E2B tests and patch_e2b#160
yanghanlin wants to merge 3 commits intoopenkruise:masterfrom
yanghanlin:feature/e2b-test-improvements

Conversation

@yanghanlin
Copy link
Copy Markdown

Ⅰ. Describe what this PR does

  • Makes test SandboxSet images (runtime image and code interpreter image) and runtime image entrypoint configurable
  • Adds requests dependency and -n default to resolve CI issues
  • Removes -x flag from pytest invocation for complete test suite execution
  • Updates patch_e2b to use client-side environment variable E2B_DOMAIN and ignore server-side configured domain when possible

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

- Add --runtime-image and --code-interpreter-image parameters to e2b workflow files
- Update run-e2b-e2e-test.sh to accept --runtime-image, --code-interpreter-image, and --runtime-entrypoint CLI arguments
- Use sed to substitute templated variables in sandboxset yaml before running tests
- Replace hardcoded images in sandboxset-code-interpreter.yaml with ${RUNTIME_IMAGE}, ${CODE_INTERPRETER_IMAGE}, and ${RUNTIME_ENTRYPOINT} placeholders
- Remove -x flag from pytest to continue running tests after failures
Add support for overriding the sandbox domain via E2B_DOMAIN environment
variable in both __sandbox_get_host and __connection_config_get_host methods.
This enables flexible domain configuration for testing environments without
relying on server-side configs.
…s dependency

- Add `-n default` namespace flag to kubectl commands in utils.py
  - `kubectl get sbx` → `kubectl get sbx -n default`
  - `kubectl describe pod` → include `-n default`
  - `kubectl logs` commands → include `-n default`
- Add `requests` package to requirements.txt for E2B test utilities
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link
Copy Markdown

Welcome @yanghanlin! It looks like this is your first PR to openkruise/agents 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.03%. Comparing base (52e4275) to head (97767a1).
⚠️ Report is 100 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   54.03%   54.03%           
=======================================
  Files          94       94           
  Lines        5365     5365           
=======================================
  Hits         2899     2899           
  Misses       2247     2247           
  Partials      219      219           
Flag Coverage Δ
unittests 54.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kruise-bot
Copy link
Copy Markdown

@yanghanlin: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants