test(e2b): update E2B tests and patch_e2b#160
test(e2b): update E2B tests and patch_e2b#160yanghanlin wants to merge 3 commits intoopenkruise:masterfrom
Conversation
- Add --runtime-image and --code-interpreter-image parameters to e2b workflow files
- Update run-e2b-e2e-test.sh to accept --runtime-image, --code-interpreter-image, and --runtime-entrypoint CLI arguments
- Use sed to substitute templated variables in sandboxset yaml before running tests
- Replace hardcoded images in sandboxset-code-interpreter.yaml with ${RUNTIME_IMAGE}, ${CODE_INTERPRETER_IMAGE}, and ${RUNTIME_ENTRYPOINT} placeholders
- Remove -x flag from pytest to continue running tests after failures
Add support for overriding the sandbox domain via E2B_DOMAIN environment variable in both __sandbox_get_host and __connection_config_get_host methods. This enables flexible domain configuration for testing environments without relying on server-side configs.
…s dependency - Add `-n default` namespace flag to kubectl commands in utils.py - `kubectl get sbx` → `kubectl get sbx -n default` - `kubectl describe pod` → include `-n default` - `kubectl logs` commands → include `-n default` - Add `requests` package to requirements.txt for E2B test utilities
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @yanghanlin! It looks like this is your first PR to openkruise/agents 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 54.03% 54.03%
=======================================
Files 94 94
Lines 5365 5365
=======================================
Hits 2899 2899
Misses 2247 2247
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yanghanlin: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ⅰ. Describe what this PR does
requestsdependency and-n defaultto resolve CI issues-xflag from pytest invocation for complete test suite executionpatch_e2bto use client-side environment variableE2B_DOMAINand ignore server-side configured domain when possibleⅡ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews