fix: resolve NPE when using built-in API key#164
Open
LegGasai wants to merge 1 commit intoopenkruise:masterfrom
Open
fix: resolve NPE when using built-in API key#164LegGasai wants to merge 1 commit intoopenkruise:masterfrom
LegGasai wants to merge 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @LegGasai! It looks like this is your first PR to openkruise/agents 🎉 |
LegGasai
force-pushed
the
fix_api_key
branch
from
e2e87d6 to
fb51a25
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 55.50% 55.42% -0.08%
==========================================
Files 94 94
Lines 5378 5378
==========================================
- Hits 2985 2981 -4
- Misses 2169 2173 +4
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
cc @furykerry Could you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR fixes a NullPointerException that occurs when calling the
ListByOwnerAPI to list API keys for a given owner.The issue happens when returning a list of API keys that includes the
system built-in admin API key(e.g., some-api-key created during deployment). The built-in key has itsCreatedByfield set to null:{ "createdAt": "2026-02-12T12:37:10.131568431Z", "id": "xxxxxx", "key": "some-api-key", "name": "admin", "createdBy": null }In the code:
pkg/servers/e2b/keys/keys.go#236if apikey.ID == owner || apikey.CreatedBy.ID == owner { ... }the
apikey.CreatedBy.IDdereference causes a panic whenCreatedByis nil.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews