Skip to content

feature(sandbox-manager): add rate limiter to all apis and introduce a better limiter framework#172

Open
AiRanthem wants to merge 1 commit intoopenkruise:masterfrom
AiRanthem:feature/base-rate-limiter-260304
Open

feature(sandbox-manager): add rate limiter to all apis and introduce a better limiter framework#172
AiRanthem wants to merge 1 commit intoopenkruise:masterfrom
AiRanthem:feature/base-rate-limiter-260304

Conversation

@AiRanthem
Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.27%. Comparing base (752e1a5) to head (6479b82).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sandbox-manager/infra/sandboxcr/claim.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   57.10%   57.27%   +0.16%     
==========================================
  Files          94       96       +2     
  Lines        5761     5783      +22     
==========================================
+ Hits         3290     3312      +22     
  Misses       2234     2234              
  Partials      237      237              
Flag Coverage Δ
unittests 57.27% <98.27%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kruise-bot kruise-bot added size/XL and removed size/L labels Mar 4, 2026
@zmberg
Copy link
Copy Markdown
Member

zmberg commented Mar 6, 2026

/lgtm

@kruise-bot
Copy link
Copy Markdown

@AiRanthem: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…a better limiter framework

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
@AiRanthem AiRanthem force-pushed the feature/base-rate-limiter-260304 branch from 6479b82 to a25a77c Compare March 31, 2026 03:17
@kruise-bot kruise-bot removed the lgtm label Mar 31, 2026
@kruise-bot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants