Skip to content

feat(peer): replace the old heartbeat mechanism with memberlist#185

Open
AiRanthem wants to merge 1 commit intoopenkruise:masterfrom
AiRanthem:feature/memberlist-260309
Open

feat(peer): replace the old heartbeat mechanism with memberlist#185
AiRanthem wants to merge 1 commit intoopenkruise:masterfrom
AiRanthem:feature/memberlist-260309

Conversation

@AiRanthem
Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AiRanthem AiRanthem force-pushed the feature/memberlist-260309 branch 2 times, most recently from 8f96414 to 4788f28 Compare March 10, 2026 08:03
@AiRanthem AiRanthem force-pushed the feature/memberlist-260309 branch from 0625157 to a0916f9 Compare March 10, 2026 10:09
@AiRanthem AiRanthem force-pushed the feature/memberlist-260309 branch from a0916f9 to 4ae4cc2 Compare March 23, 2026 04:06
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 75.55556% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.83%. Comparing base (95ba21c) to head (32b4de4).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sandbox-manager/core.go 19.56% 37 Missing ⚠️
pkg/peers/memberlist.go 93.51% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   61.72%   63.83%   +2.11%     
==========================================
  Files         104      105       +1     
  Lines        6681     6731      +50     
==========================================
+ Hits         4124     4297     +173     
+ Misses       2290     2163     -127     
- Partials      267      271       +4     
Flag Coverage Δ
unittests 63.83% <75.55%> (+2.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
@AiRanthem AiRanthem force-pushed the feature/memberlist-260309 branch from 4ae4cc2 to 32b4de4 Compare March 23, 2026 07:52
@kruise-bot
Copy link
Copy Markdown

@AiRanthem: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants