[WIP]feat: support inplace CPU resize for warm pool sandboxes#228
Open
PersistentJZH wants to merge 1 commit intoopenkruise:masterfrom
Open
[WIP]feat: support inplace CPU resize for warm pool sandboxes#228PersistentJZH wants to merge 1 commit intoopenkruise:masterfrom
PersistentJZH wants to merge 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
PersistentJZH
force-pushed
the
feat/support-inplace-resize-cpu
branch
from
767e305 to
1d13c3b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| agentsapiv1alpha1.PodLabelTemplateHash: revision, | ||
| } | ||
| if len(patchSpec.Containers) == 0 { | ||
| return fmt.Sprintf(`{"metadata":{"annotations":%s,"labels":%s}}`, utils.DumpJson(annotations), utils.DumpJson(labels)) |
Check failure
Code scanning / CodeQL
Potentially unsafe quoting Critical
PersistentJZH
force-pushed
the
feat/support-inplace-resize-cpu
branch
from
1d13c3b to
b3b25d4
Compare
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
PersistentJZH
force-pushed
the
feat/support-inplace-resize-cpu
branch
from
b3b25d4 to
87510f7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 62.46% 63.60% +1.14%
==========================================
Files 106 106
Lines 6855 7213 +358
==========================================
+ Hits 4282 4588 +306
- Misses 2301 2326 +25
- Partials 272 299 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
support inplace CPU resize for warm pool sandboxes, both support for e2b sandbox claim api and sandbox claim crd.
Ⅱ. Does this pull request fix one issue?
#68
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews