Add unit tests for util functions#293
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
9099293 to
a1557ea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 47.52% 47.42% -0.11%
==========================================
Files 63 65 +2
Lines 9799 9890 +91
==========================================
+ Hits 4657 4690 +33
- Misses 4585 4643 +58
Partials 557 557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
|
@furykerry can you help me with why 'codecov/project' fails saying low coverage. it seems to be 100% as i can check on terminal |
What this PR does / Why we need it
The utility functions in
pkg/webhook/util/util.goare responsible for configuring the webhook from environment variables. These functions previously lacked unit test coverage, making it hard to verify their behavior or prevent future regressions.This PR adds unit tests to ensure this critical configuration logic is reliable and works as expected.
Key Scenarios Covered