[Feature] Add start and end time tracking for canary batches#304
Open
chethanac15 wants to merge 6 commits intoopenkruise:masterfrom
Open
[Feature] Add start and end time tracking for canary batches#304chethanac15 wants to merge 6 commits intoopenkruise:masterfrom
chethanac15 wants to merge 6 commits intoopenkruise:masterfrom
Conversation
|
Welcome @chethanac15! It looks like this is your first PR to openkruise/rollouts 🎉 |
- Add BatchStartTime field to BatchReleaseCanaryStatus in both v1alpha1 and v1beta1 - Add CurrentStepStartTime and CurrentStepEndTime fields to Rollout CanaryStatus - Set BatchStartTime when a batch enters UpgradingBatchState - Reset BatchStartTime when moving to next batch or restarting - Sync timing information from BatchRelease to Rollout status - Update conversion functions to handle new timing fields - Regenerate deepcopy files This addresses issue openkruise#112 to track start and end times for every canary batch/step. Signed-off-by: Chethan A C <acchethan15@gmail.com>
Signed-off-by: Chethan A C <acchethan15@gmail.com>
Signed-off-by: Chethan A C <acchethan15@gmail.com>
e7160da to
7bebb24
Compare
…ile paths Signed-off-by: Chethan A C <acchethan15@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… formatting Signed-off-by: Chethan A C <acchethan15@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the feature requested in issue #112 to record the start time and end time for every canary batch in Rollout.
Changes Made
BatchStartTimefield toBatchReleaseCanaryStatusin both v1alpha1 and v1beta1CurrentStepStartTimeandCurrentStepEndTimefields to RolloutCanaryStatusBenefits
Testing
Related Issue
Fixes #112
Type of Change
Checklist