feat(ServerTextPosition): implement comparison operators#597
Merged
tombh merged 2 commits intoopenlawlibrary:mainfrom Mar 25, 2026
Merged
feat(ServerTextPosition): implement comparison operators#597tombh merged 2 commits intoopenlawlibrary:mainfrom
tombh merged 2 commits intoopenlawlibrary:mainfrom
Conversation
4dee91e to
52174f1
Compare
Contributor
Author
|
I've opened a PR to implement similar overlap and inclusion functions in lsprotocol itself as well: microsoft/lsprotocol#448 |
52174f1 to
b3b960c
Compare
Contributor
Author
|
Hi @tombh , looks like this fell through the cracks and didn't make it into the latest release (maybe because it was a draft? do let me know if that was it or if there's something else I should have done to get attention on this ^^); I think it would be good to get at least the first commit into a patch release, as the comparison operators that worked on the |
tombh
approved these changes
Mar 25, 2026
b3b960c to
77155f4
Compare
Collaborator
|
Ah sorry, yes I saw the DRAFT status and thought you were still working on it. No worries we can just do a point release. |
Contributor
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
lsprotocol's
Positiontype implements comparison operators, which can be quite convenient when implementing a language server. Mirror this functionality in ServerTextPosition.Code review checklist (for code reviewer to complete)
Automated linters
You can run the lints that are run on CI locally with: