feat: add _publication endpoit for the historical versions#105
Open
feat: add _publication endpoit for the historical versions#105
Conversation
Replace silent GenericError conversion with explicit tracing::error before propagating bind failures in both the publish and git servers, so the actual OS error (e.g. address already in use) is visible.
n-dusan
reviewed
Mar 28, 2026
Contributor
n-dusan
left a comment
n-dusan
left a comment
There was a problem hiding this comment.
Tested locally and this works great! small suggestion below. Then let's merge
Contributor
There was a problem hiding this comment.
suggestion: let's move notifications.rs to date directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Related to #104
Code review checklist (for code reviewer to complete)
Automated tests, benchmarks and linters
You can run the tests, lints and benchmarks that are run on CI locally with: