Merged
Conversation
…heck for no-op speedup Replaces the old reset_to_last_validated_commit pipeline step with check_if_local_repos_match_lvc, which checks whether the auth repo HEAD and all on-disk target repos match their last-validated commits. If consistent, check_if_repo_is_synced_with_remote can run and skip the full update (clone-to-temp, TUF validation, etc.) when there are no upstream changes.
Resolve the updater pipeline merge conflict by keeping the local LVC consistency fast path and the moved clean-check ordering. Also preserve the dirty-state test updates so those cases still expect failures only when there are upstream commits to pull.
- Change --lvc flag to --lvc/--no-lvc with default True in `taf repo reset` - Update UpdateFailedError messages to suggest `taf repo reset` alongside --force - Update LVC_NOT_IN_REPO_PATTERN test regex to match new message - Add info log when checking local consistency with last validated data
n-dusan
approved these changes
Apr 14, 2026
…rce is set When local repos don't match last_validated_data and the updater is called with --force, attempt a reset to LVC before proceeding. If reset fails (e.g. LVC commit not in local repo or not on default branch), fall through to full validation which recovers the state on its own. Also fixes _perform_checks to always fail when the auth commit is not on the default branch, rather than attempting a reset_to_commit that would never succeed.
sale3
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Adds an early-exit path to the update pipeline so that when there are no remote changes and the local state is already consistent, the full validation is skipped.
Added a local consistency check (
check_if_local_repos_match_lvc). Before hitting the remote, the pipeline now verifies that the auth repo and all target repos on disk match the state recorded in last_validated_data. If everything lines up, local_repos_consistent is set and subsequent steps that would otherwise re-validate the full history are skipped.determine_start_commits short-circuit: when local_repos_consistent=True and the previous update was not partial, the function returns early instead of re-walking all target commits.
taf repo reset --lvc default changed: the flag is now --lvc/--no-lvc defaulting to True, so resetting the last validated commit is the default behaviour unless explicitly opted out.
Improved failure messages: UpdateFailedError messages now suggest taf repo reset as the preferred recovery path alongside the existing --force option.
Closes #676
Code review checklist (for code reviewer to complete)